mirror/rogueserver
1
0
Fork 0
mirror of https://github.com/pagefaultgames/rogueserver.git synced 2025-04-29 07:36:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use r.PostFormValue instead of r.Form.Get

Browse Source
This commit is contained in:
Pancakes 2025-04-25 19:38:18 -04:00
parent e48b092de4
commit ef9b659127
No known key found for this signature in database
GPG Key ID: 5792877BFA27DC8F
1 changed files with 12 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
api/endpoints.go
View File

@ -81,13 +81,7 @@ func handleAccountInfo(w http.ResponseWriter, r *http.Request) {
} }
func handleAccountRegister(w http.ResponseWriter, r *http.Request) { func handleAccountRegister(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm() err := account.Register(r.PostFormValue("username"), r.PostFormValue("password"))
if err != nil {
httpError(w, r, fmt.Errorf("failed to parse request form: %s", err), http.StatusBadRequest)
return
}
err = account.Register(r.Form.Get("username"), r.Form.Get("password"))
if err != nil { if err != nil {
httpError(w, r, err, http.StatusInternalServerError) httpError(w, r, err, http.StatusInternalServerError)
return return
@ -97,13 +91,7 @@ func handleAccountRegister(w http.ResponseWriter, r *http.Request) {
} }
func handleAccountLogin(w http.ResponseWriter, r *http.Request) { func handleAccountLogin(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm() response, err := account.Login(r.PostFormValue("username"), r.PostFormValue("password"))
if err != nil {
httpError(w, r, fmt.Errorf("failed to parse request form: %s", err), http.StatusBadRequest)
return
}
response, err := account.Login(r.Form.Get("username"), r.Form.Get("password"))
if err != nil { if err != nil {
httpError(w, r, err, http.StatusInternalServerError) httpError(w, r, err, http.StatusInternalServerError)
return return
@ -113,19 +101,13 @@ func handleAccountLogin(w http.ResponseWriter, r *http.Request) {
} }
func handleAccountChangePW(w http.ResponseWriter, r *http.Request) { func handleAccountChangePW(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
httpError(w, r, fmt.Errorf("failed to parse request form: %s", err), http.StatusBadRequest)
return
}
uuid, err := uuidFromRequest(r) uuid, err := uuidFromRequest(r)
if err != nil { if err != nil {
httpError(w, r, err, http.StatusUnauthorized) httpError(w, r, err, http.StatusUnauthorized)
return return
} }
err = account.ChangePW(uuid, r.Form.Get("password")) err = account.ChangePW(uuid, r.PostFormValue("password"))
if err != nil { if err != nil {
httpError(w, r, err, http.StatusInternalServerError) httpError(w, r, err, http.StatusInternalServerError)
return return
@ -666,12 +648,6 @@ func handleProviderLogout(w http.ResponseWriter, r *http.Request) {
} }
func handleAdminDiscordLink(w http.ResponseWriter, r *http.Request) { func handleAdminDiscordLink(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
httpError(w, r, fmt.Errorf("failed to parse request form: %s", err), http.StatusBadRequest)
return
}
uuid, err := uuidFromRequest(r) uuid, err := uuidFromRequest(r)
if err != nil { if err != nil {
httpError(w, r, err, http.StatusUnauthorized) httpError(w, r, err, http.StatusUnauthorized)
@ -690,8 +666,8 @@ func handleAdminDiscordLink(w http.ResponseWriter, r *http.Request) {
return return
} }
username := r.Form.Get("username") username := r.PostFormValue("username")
discordId := r.Form.Get("discordId") discordId := r.PostFormValue("discordId")
// this does a quick call to make sure the username exists on the server before allowing the rest of the code to run // this does a quick call to make sure the username exists on the server before allowing the rest of the code to run
// this calls error value 404 (StatusNotFound) if there's no data; this means the username does not exist in the server // this calls error value 404 (StatusNotFound) if there's no data; this means the username does not exist in the server
@ -719,12 +695,6 @@ func handleAdminDiscordLink(w http.ResponseWriter, r *http.Request) {
} }
func handleAdminDiscordUnlink(w http.ResponseWriter, r *http.Request) { func handleAdminDiscordUnlink(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
httpError(w, r, fmt.Errorf("failed to parse request form: %s", err), http.StatusBadRequest)
return
}
uuid, err := uuidFromRequest(r) uuid, err := uuidFromRequest(r)
if err != nil { if err != nil {
httpError(w, r, err, http.StatusUnauthorized) httpError(w, r, err, http.StatusUnauthorized)
@ -743,8 +713,8 @@ func handleAdminDiscordUnlink(w http.ResponseWriter, r *http.Request) {
return return
} }
username := r.Form.Get("username") username := r.PostFormValue("username")
discordId := r.Form.Get("discordId") discordId := r.PostFormValue("discordId")
switch { switch {
case username != "": case username != "":
@ -783,12 +753,6 @@ func handleAdminDiscordUnlink(w http.ResponseWriter, r *http.Request) {
} }
func handleAdminGoogleLink(w http.ResponseWriter, r *http.Request) { func handleAdminGoogleLink(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
httpError(w, r, fmt.Errorf("failed to parse request form: %s", err), http.StatusBadRequest)
return
}
uuid, err := uuidFromRequest(r) uuid, err := uuidFromRequest(r)
if err != nil { if err != nil {
httpError(w, r, err, http.StatusUnauthorized) httpError(w, r, err, http.StatusUnauthorized)
@ -807,8 +771,8 @@ func handleAdminGoogleLink(w http.ResponseWriter, r *http.Request) {
return return
} }
username := r.Form.Get("username") username := r.PostFormValue("username")
googleId := r.Form.Get("googleId") googleId := r.PostFormValue("googleId")
// this does a quick call to make sure the username exists on the server before allowing the rest of the code to run // this does a quick call to make sure the username exists on the server before allowing the rest of the code to run
// this calls error value 404 (StatusNotFound) if there's no data; this means the username does not exist in the server // this calls error value 404 (StatusNotFound) if there's no data; this means the username does not exist in the server
@ -836,12 +800,6 @@ func handleAdminGoogleLink(w http.ResponseWriter, r *http.Request) {
} }
func handleAdminGoogleUnlink(w http.ResponseWriter, r *http.Request) { func handleAdminGoogleUnlink(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
httpError(w, r, fmt.Errorf("failed to parse request form: %s", err), http.StatusBadRequest)
return
}
uuid, err := uuidFromRequest(r) uuid, err := uuidFromRequest(r)
if err != nil { if err != nil {
httpError(w, r, err, http.StatusUnauthorized) httpError(w, r, err, http.StatusUnauthorized)
@ -860,8 +818,8 @@ func handleAdminGoogleUnlink(w http.ResponseWriter, r *http.Request) {
return return
} }
username := r.Form.Get("username") username := r.PostFormValue("username")
googleId := r.Form.Get("googleId") googleId := r.PostFormValue("googleId")
switch { switch {
case username != "": case username != "":
@ -900,12 +858,6 @@ func handleAdminGoogleUnlink(w http.ResponseWriter, r *http.Request) {
} }
func handleAdminSearch(w http.ResponseWriter, r *http.Request) { func handleAdminSearch(w http.ResponseWriter, r *http.Request) {
err := r.ParseForm()
if err != nil {
httpError(w, r, fmt.Errorf("failed to parse request form: %s", err), http.StatusBadRequest)
return
}
uuid, err := uuidFromRequest(r) uuid, err := uuidFromRequest(r)
if err != nil { if err != nil {
httpError(w, r, err, http.StatusUnauthorized) httpError(w, r, err, http.StatusUnauthorized)
@ -924,7 +876,7 @@ func handleAdminSearch(w http.ResponseWriter, r *http.Request) {
return return
} }
username := r.Form.Get("username") username := r.PostFormValue("username")
// this does a quick call to make sure the username exists on the server before allowing the rest of the code to run // this does a quick call to make sure the username exists on the server before allowing the rest of the code to run
// this calls error value 404 (StatusNotFound) if there's no data; this means the username does not exist in the server // this calls error value 404 (StatusNotFound) if there's no data; this means the username does not exist in the server