V0.2.7

Update translations
Fix the translation in t55xxtab
(QTranslator must be created before wigets)
Reduce unnecessary translations

CHANGELOG.md

@@ -2,6 +2,16 @@
 
 [中文](doc/CHANGELOG/CHANGELOG_zh_CN.md)  
 
+### V0.2.7
++ Fix writing to Block 0 failure when using with RRG repo v4.15864  
++ Disable disconnection detection on Linux/macOS by default  
++ Fix a little bug in the config file  
++ Fix the Trailer Decoder  
++ Show more details in the Trailer Decoder  
++ Add dark theme(from https://github.com/ColinDuquesnoy/QDarkStyleSheet)  
++ Add support for customizable theme, opacity and fonts  
++ Fix translations  
+
 ### V0.2.6
 + Add support for Iceman/RRG repo v4.15864 [#37](https://github.com/wh201906/Proxmark3GUI/issues/37)  
 + Optimize mifare classic block writing logic  

README.md

@@ -1,7 +1,10 @@
 # Proxmark3GUI
-![downloads](https://img.shields.io/github/downloads/wh201906/Proxmark3GUI/total)  
+[![downloads](https://img.shields.io/github/downloads/wh201906/Proxmark3GUI/total?label=GitHub%20release%20downloads)](https://github.com/wh201906/Proxmark3GUI/releases)  
+[![downloads](https://img.shields.io/sourceforge/dt/proxmark3gui.svg?label=SourceForge%20downloads)](https://sourceforge.net/projects/proxmark3gui/)  
 
-A cross-platform GUI for [Proxmark3](https://github.com/Proxmark/proxmark3) client
+A cross-platform GUI for [Proxmark3](https://github.com/Proxmark/proxmark3)/[Proxmark3 Iceman fork](https://github.com/RfidResearchGroup/proxmark3) client  
+
+(The [orignal Proxmark3 repo](https://github.com/Proxmark/proxmark3) has been unmaintained for a long time. I personally suggest using the [Proxmark3 Iceman fork](https://github.com/RfidResearchGroup/proxmark3))
 
 [中文介绍](doc/README/README_zh_CN.md)
 
@@ -32,13 +35,6 @@ A cross-platform GUI for [Proxmark3](https://github.com/Proxmark/proxmark3) clie
 
 ***
 
-## About Iceman fork/repo
-
-The [Iceman fork/repo](https://github.com/RfidResearchGroup/proxmark3) has more powerful functions. These guys even developed a new hardware called Proxmark3 RDV4 with smart card support. But the official repo and the Iceman repo is not fully compatible.  
-This GUI is compatible with Iceman/RRG repo(tested on v4.13441)  
-
-***
-
 ## About Compiled Windows clients
 
 A cool guy [Gator96100](https://github.com/Gator96100) creates [ProxSpace](https://github.com/Gator96100/ProxSpace) and makes it possible to compile both the firmware and the client on Windows.  
@@ -48,17 +44,45 @@ Great thanks to him.
 
 ***
 
-## Build on Linux
+## Download binaries for Windows 
+You can download pre-built Windows binaries in [release](https://github.com/wh201906/Proxmark3GUI/releases) page  
+`Vx.x.x-win64.7z` only contains the GUI  
+`Vx.x.x-win64-xxxxxxx.7z` contains the GUI and corresponding client. You just need to open `Vx.x.x-win64-xxxxxxx\GUI\Proxmark3GUI.exe`  
 
-    cd ~
+You can also download them in SourceForge  
-    sudo apt-get update
+[![Download Proxmark3GUI](https://a.fsdn.com/con/app/sf-download-button)](https://sourceforge.net/projects/proxmark3gui/files/latest/download)  
-    sudo apt-get install qt5-default libqt5serialport5 libqt5serialport5-dev 
+
-    git clone https://github.com/wh201906/Proxmark3GUI.git --depth=1
+## Build on Linux
-    cd Proxmark3GUI
+```
-    mkdir build && cd build
+cd ~
-    qmake ../src
+sudo apt-get update
-    make -j4 && make clean
+sudo apt-get install git build-essential
-    ./Proxmark3GUI
+sudo apt-get install qt5-default libqt5serialport5-dev
+git clone https://github.com/wh201906/Proxmark3GUI.git --depth=1
+cd Proxmark3GUI
+mkdir build && cd build
+qmake ../src
+make -j4 && make clean
+./Proxmark3GUI
+```
+
+## Build on macOS
+```
+cd ~
+brew update
+brew install qt@5
+brew link qt5 --force
+git clone https://github.com/wh201906/Proxmark3GUI.git --depth=1
+cd Proxmark3GUI
+mkdir build && cd build
+qmake ../src
+make -j4 && make clean
+open Proxmark3GUI.app
+```
+
+> In order for the GUI to connect to the device in macOS, you'd need to tweak the settings a little bit
+
+![macOS_settings](doc/README/macOS_settings.png)
 
 ***
 ## Tutorial

config/config_rrgv4.15864.json

@@ -134,7 +134,7 @@
         },
         "//": "When writing a block, if the result is not empty and doesn't contain the failed flag, the function will return true",
         "normal write block": {
-            "cmd": "hf mf wrbl --blk <block> -<key type> -k <key> -d <data>",
+            "cmd": "hf mf wrbl --blk <block> -<key type> -k <key> -d <data> --force",
             "key type": {
                 "A": "a",
                 "B": "b"
@@ -238,4 +238,4 @@
             "t55x7 flag": ""
         }
     }
-}
+}

doc/CHANGELOG/CHANGELOG_zh_CN.md

@@ -2,6 +2,16 @@
 
 [English](../../CHANGELOG.md)  
 
+### V0.2.7
++ 修复使用冰人版v4.15864时无法写入块0的问题  
++ 默认关闭Linux/macOS系统下对PM3硬件断连的检测  
++ 修复配置文件中的小Bug  
++ 修复访问控制位解码器  
++ 在访问控制位解码器中显示更多细节  
++ 添加暗黑主题(源于https://github.com/ColinDuquesnoy/QDarkStyleSheet)  
++ 支持自定义主题，透明度，字体  
++ 修复若干翻译问题  
+
 ### V0.2.6
 + 支持冰人版客户端 v4.15864 [#37](https://github.com/wh201906/Proxmark3GUI/issues/37)  
 + 优化Mifare Classic卡写卡逻辑  

doc/README/README_zh_CN.md

@@ -1,7 +1,10 @@
 # Proxmark3GUI
-![downloads](https://img.shields.io/github/downloads/wh201906/Proxmark3GUI/total)  
+[![downloads](https://img.shields.io/github/downloads/wh201906/Proxmark3GUI/total?label=GitHub%E4%B8%8B%E8%BD%BD%E9%87%8F)](https://github.com/wh201906/Proxmark3GUI/releases)  
+[![downloads](https://img.shields.io/sourceforge/dt/proxmark3gui.svg?label=SourceForge%E4%B8%8B%E8%BD%BD%E9%87%8F)](https://sourceforge.net/projects/proxmark3gui/)  
 
-一个自制的[Proxmark3](https://github.com/Proxmark/proxmark3) GUI，可在Windows/Linux系统下运行
+一个自制的[Proxmark3](https://github.com/Proxmark/proxmark3) GUI，可在Windows/Linux/macOS系统下运行，支持[官方版](https://github.com/Proxmark/proxmark3)/[冰人版](https://github.com/RfidResearchGroup/proxmark3)客户端和固件  
+
+(目前[官方版](https://github.com/Proxmark/proxmark3)已停更超过一年，推荐使用[冰人版](https://github.com/RfidResearchGroup/proxmark3)固件和客户端)
 
 [English](../../README.md)
 
@@ -28,13 +31,7 @@
 ## 预览图
 ![preview](preview_zh_CN.png)  
 
- [更多预览](../preview/previews.md)  
+[更多预览](../preview/previews.md)  
-
-***
-
- ## 关于冰人版
- [冰人版](https://github.com/RfidResearchGroup/proxmark3)(Iceman/RRG)的客户端和固件更新更为激进，相比官方版具有更多的功能  
- 此GUI所有功能均兼容冰人版（在v4.13441上测试通过）  
 
 ***
 
@@ -47,17 +44,45 @@ release页面中有含客户端的GUI。这个GUI也可以搭配你自己的客
 
 ***
 
-## 在Linux系统下编译
+## 下载Windows版本
+[release](https://github.com/wh201906/Proxmark3GUI/releases) 页面当中包含了编译好的Windows程序，解压后即可使用  
+`Vx.x.x-win64.7z`是不带客户端的纯GUI程序，可配合已有的客户端使用  
+`Vx.x.x-win64-xxxxxxx.7z`包含了对应的客户端，打开`Vx.x.x-win64-xxxxxxx\GUI\Proxmark3GUI.exe`即可使用  
 
-    cd ~
+SourceForge平台上也可下载  
-    sudo apt-get update
+[![Download Proxmark3GUI](https://a.fsdn.com/con/app/sf-download-button)](https://sourceforge.net/projects/proxmark3gui/files/latest/download)  
-    sudo apt-get install qt5-default libqt5serialport5 libqt5serialport5-dev 
+
-    git clone https://github.com/wh201906/Proxmark3GUI.git --depth=1
+## 在Linux系统下编译
-    cd Proxmark3GUI
+```
-    mkdir build && cd build
+cd ~
-    qmake ../src
+sudo apt-get update
-    make -j4 && make clean
+sudo apt-get install git build-essential
-    ./Proxmark3GUI
+sudo apt-get install qt5-default libqt5serialport5-dev 
+git clone https://github.com/wh201906/Proxmark3GUI.git --depth=1
+cd Proxmark3GUI
+mkdir build && cd build
+qmake ../src
+make -j4 && make clean
+./Proxmark3GUI
+```
+
+## 在macOS系统下编译
+```
+cd ~
+brew update
+brew install qt@5
+brew link qt5 --force
+git clone https://github.com/wh201906/Proxmark3GUI.git --depth=1
+cd Proxmark3GUI
+mkdir build && cd build
+qmake ../src
+make -j4 && make clean
+open Proxmark3GUI.app
+```
+
+> 为使GUI在macOS下正确连接设备，需要更改一些设置
+
+![macOS_settings](macOS_settings.png)
 
 ***
 ## 教程

doc/tutorial/Quickstart/quickstart.md

@@ -41,5 +41,26 @@
 (3) You might need to change "\<port\>" to "/dev/\<port\>" in "Settings"->"Start arguments" editbox  
 ![](args_linux.png)  
 
-(4) If you are using Raspbian(Raspberry OS), you might need to check "Keep the client active even the PM3 hardware is disconnected." in the "Steeings" panel  
+(4) If you are using Raspbian(Raspberry OS), you might need to check "Keep the client active even the PM3 hardware is disconnected." in the "Settings" panel  
-![](keep.png)  
+![](keep.png)  
+
+## About preload script
+The client might refer to some environment variables to load dependencies  
+For example, the RRG client on Windows requires these environment variables  
+```
+QT_PLUGIN_PATH=<client path>\libs\
+QT_QPA_PLATFORM_PLUGIN_PATH=<client path>\libs\
+PATH=<client path>\libs\;<client path>\libs\shell\;<old PATH variable>
+MSYSTEM=MINGW64
+```
+So the GUI will run "\<client path\>\\setup.bat" before loading the client, which will set the environment variables to the client properly. The script will not affect the system environment variables.  
+The contents of setup.bat are as follows  
+```
+@echo off
+set "HOME=%~dp0"
+set "QT_PLUGIN_PATH=%HOME%\libs\"
+set "QT_QPA_PLATFORM_PLUGIN_PATH=%QT_PLUGIN_PATH%"
+set "PATH=%QT_PLUGIN_PATH%;%QT_PLUGIN_PATH%shell\;%PATH%"
+set MSYSTEM=MINGW64
+```
+You can write your own script by referring to it if you need other client, then input the script path in the "Preload script path" editbox.  

doc/tutorial/Quickstart/quickstart_zh_CN.md

@@ -46,4 +46,26 @@
 ![](args_linux_zh_CN.png)  
 
 (4) 若使用树莓派Raspbian系统且连接成功若干秒后PM3会自动断开，则需要在“设置”面板中勾选“在PM3断开后保持客户端运行”  
-![](keep_zh_CN.png)  
+![](keep_zh_CN.png)  
+
+## 预加载脚本
+客户端在运行时可能需要使用某些环境变量以解决依赖问题  
+例如，Windows平台下的冰人客户端运行时需要以下环境变量
+```
+QT_PLUGIN_PATH=<客户端路径>\libs\
+QT_QPA_PLATFORM_PLUGIN_PATH=<客户端路径>\libs\
+PATH=<客户端路径>\libs\;<客户端路径>\libs\shell\;<原PATH变量>
+MSYSTEM=MINGW64
+```
+因此，GUI会在加载客户端之前先运行"\<客户端路径\>\\setup.bat"，从而在加载客户端时使用正确的环境变量。这些设置不会影响系统环境变量，仅对客户端本身有效  
+
+setup.bat的内容如下
+```
+@echo off
+set "HOME=%~dp0"
+set "QT_PLUGIN_PATH=%HOME%\libs\"
+set "QT_QPA_PLATFORM_PLUGIN_PATH=%QT_PLUGIN_PATH%"
+set "PATH=%QT_PLUGIN_PATH%;%QT_PLUGIN_PATH%shell\;%PATH%"
+set MSYSTEM=MINGW64
+```
+如果需要使用其它客户端，你可以参考此文件编写自己的脚本，然后将其填入“预加载脚本路径”当中  

src/Proxmark3GUI.pro

@@ -59,11 +59,13 @@ qnx: target.path = /tmp/$${TARGET}/bin
 else: unix:!android: target.path = /opt/$${TARGET}/bin
 !isEmpty(target.path): INSTALLS += target
 
-VERSION = 0.2.6
+VERSION = 0.2.7
 QMAKE_TARGET_PRODUCT = "Proxmark3GUI"
 QMAKE_TARGET_DESCRIPTION = "Proxmark3GUI"
 QMAKE_TARGET_COMPANY = "wh201906"
 
 RESOURCES += \
     ../i18n/language.qrc \
-    ../config/config.qrc
+    ../config/config.qrc \
+    qdarkstyle/dark/darkstyle.qrc \
+    qdarkstyle/light/lightstyle.qrc

src/common/util.cpp

@@ -128,7 +128,7 @@ bool Util::chooseLanguage(QSettings* guiSettings, QMainWindow* window)
         return false;
     if(langMap[selectedText] == "(ext)")
     {
-        QString extPath = QFileDialog::getOpenFileName(nullptr, tr("Select the translation file:"));
+        QString extPath = QFileDialog::getOpenFileName(window, tr("Select the translation file:"));
         if(extPath.isEmpty())
             return false;
 

src/common/util.h

@@ -59,7 +59,7 @@ public:
     static ClientType getClientType();
     static int rawTabIndex;
     static QDockWidget* rawDockPtr;
-    static bool chooseLanguage(QSettings *guiSettings, QMainWindow *window);
+    static bool chooseLanguage(QSettings *guiSettings, QMainWindow *window = nullptr);
 public slots:
     void processOutput(const QString& output);
     static void setClientType(Util::ClientType clientType);

src/main.cpp

@@ -23,7 +23,6 @@ int main(int argc, char *argv[])
     QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
     QTextCodec::setCodecForLocale(QTextCodec::codecForName("UTF-8"));
     QApplication a(argc, argv);
-    MainWindow w;
 
     QSettings* settings = new QSettings("GUIsettings.ini", QSettings::IniFormat);
     settings->setIniCodec("UTF-8");
@@ -31,9 +30,12 @@ int main(int argc, char *argv[])
     QString languageFile = settings->value("extPath").toString();
     QString languageName = settings->value("name").toString();
     settings->endGroup();
+    settings->beginGroup("UI");
+    QString theme = settings->value("Theme_Name").toString();
+    settings->endGroup();
     if(languageName == "")
     {
-        if(Util::chooseLanguage(settings, &w))
+        if(Util::chooseLanguage(settings))
         {
             settings->beginGroup("language");
             languageName = settings->value("name").toString();
@@ -50,12 +52,43 @@ int main(int argc, char *argv[])
     }
     else
         languageFile = ":/i18n/" + languageName + ".qm";
-    QTranslator* translator = new QTranslator(&w);
+
+    // Note that the translator must be created before the application's widgets.
+    QTranslator* translator = new QTranslator();
     if(translator->load(languageFile))
         a.installTranslator(translator);
     else
-        QMessageBox::information(&w, "Error", "Can't load " + languageFile + " as translation file.");
+        QMessageBox::information(nullptr, "Error", "Can't load " + languageFile + " as translation file.");
+
+    QFile* themeFile = new QFile();
+    QTextStream* themeStream = new QTextStream();
+    QString qssString = a.styleSheet(); // default behavior
+    if(theme == "(none)")
+        ;
+    else if(theme == "qdss_dark")
+    {
+        themeFile->setFileName(":/qdarkstyle/dark/darkstyle.qss");
+        themeFile->open(QFile::ReadOnly | QFile::Text);
+        themeStream->setDevice(themeFile);
+        qssString = themeStream->readAll();
+    }
+    else if(theme == "qdss_light")
+    {
+        themeFile->setFileName(":/qdarkstyle/light/lightstyle.qss");
+        themeFile->open(QFile::ReadOnly | QFile::Text);
+        themeStream->setDevice(themeFile);
+        qssString = themeStream->readAll();
+    }
+    a.setStyleSheet(qssString);
+    delete themeFile;
+    delete themeStream;
+    themeFile = nullptr;
+    themeStream = nullptr;
+
     delete settings;
+    settings = nullptr;
+
+    MainWindow w;
     w.initUI();
     w.show();
     return a.exec();

src/module/mifare.cpp

@@ -40,36 +40,39 @@ const Mifare::CardType Mifare::card_4k =
 
 const Mifare::AccessType Mifare::dataCondition[8][4] =
 {
-    {ACC_KEY_AB, ACC_KEY_AB, ACC_KEY_AB, ACC_KEY_AB},
+    // {read, write, increment, decrement/transfer/restore}
-    {ACC_KEY_AB, ACC_KEY_B, ACC_NEVER, ACC_NEVER},
+    {ACC_KEY_AB, ACC_KEY_AB, ACC_KEY_AB, ACC_KEY_AB}, // {C3x, C2x, C1x} = 0
-    {ACC_KEY_AB, ACC_NEVER, ACC_NEVER, ACC_NEVER},
+    {ACC_KEY_AB, ACC_KEY_B, ACC_NEVER, ACC_NEVER}, // {C3x, C2x, C1x} = 1
-    {ACC_KEY_AB, ACC_KEY_B, ACC_KEY_B, ACC_KEY_AB},
+    {ACC_KEY_AB, ACC_NEVER, ACC_NEVER, ACC_NEVER}, // {C3x, C2x, C1x} = 2
-    {ACC_KEY_AB, ACC_NEVER, ACC_NEVER, ACC_KEY_AB},
+    {ACC_KEY_AB, ACC_KEY_B, ACC_KEY_B, ACC_KEY_AB}, // {C3x, C2x, C1x} = 3
-    {ACC_KEY_B, ACC_NEVER, ACC_NEVER, ACC_NEVER},
+    {ACC_KEY_AB, ACC_NEVER, ACC_NEVER, ACC_KEY_AB}, // {C3x, C2x, C1x} = 4
-    {ACC_KEY_B, ACC_KEY_B, ACC_NEVER, ACC_NEVER},
+    {ACC_KEY_B, ACC_NEVER, ACC_NEVER, ACC_NEVER}, // {C3x, C2x, C1x} = 5
-    {ACC_NEVER, ACC_NEVER, ACC_NEVER, ACC_NEVER},
+    {ACC_KEY_B, ACC_KEY_B, ACC_NEVER, ACC_NEVER}, // {C3x, C2x, C1x} = 6
+    {ACC_NEVER, ACC_NEVER, ACC_NEVER, ACC_NEVER}, // {C3x, C2x, C1x} = 7
 };
 const Mifare::AccessType Mifare::trailerReadCondition[8][3] =
 {
-    {ACC_NEVER, ACC_KEY_A, ACC_KEY_A},
+    // {KEYA, Access bits, KEYB}
-    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER},
+    {ACC_NEVER, ACC_KEY_A, ACC_KEY_A}, // {C33, C23, C13} = 0
-    {ACC_NEVER, ACC_KEY_A, ACC_KEY_A},
+    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER}, // {C33, C23, C13} = 1
-    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER},
+    {ACC_NEVER, ACC_KEY_A, ACC_KEY_A}, // {C33, C23, C13} = 2
-    {ACC_NEVER, ACC_KEY_A, ACC_KEY_A},
+    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER}, // {C33, C23, C13} = 3
-    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER},
+    {ACC_NEVER, ACC_KEY_A, ACC_KEY_A}, // {C33, C23, C13} = 4
-    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER},
+    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER}, // {C33, C23, C13} = 5
-    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER},
+    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER}, // {C33, C23, C13} = 6
+    {ACC_NEVER, ACC_KEY_AB, ACC_NEVER}, // {C33, C23, C13} = 7
 };
 const Mifare::AccessType Mifare::trailerWriteCondition[8][3] =
 {
-    {ACC_KEY_A, ACC_NEVER, ACC_KEY_A},
+    // {KEYA, Access bits, KEYB}
-    {ACC_KEY_B, ACC_NEVER, ACC_KEY_B},
+    {ACC_KEY_A, ACC_NEVER, ACC_KEY_A}, // {C33, C23, C13} = 0
-    {ACC_NEVER, ACC_NEVER, ACC_NEVER},
+    {ACC_KEY_B, ACC_NEVER, ACC_KEY_B}, // {C33, C23, C13} = 1
-    {ACC_NEVER, ACC_NEVER, ACC_NEVER},
+    {ACC_NEVER, ACC_NEVER, ACC_NEVER}, // {C33, C23, C13} = 2
-    {ACC_KEY_A, ACC_KEY_A, ACC_KEY_A},
+    {ACC_NEVER, ACC_NEVER, ACC_NEVER}, // {C33, C23, C13} = 3
-    {ACC_NEVER, ACC_KEY_B, ACC_NEVER},
+    {ACC_KEY_A, ACC_KEY_A, ACC_KEY_A}, // {C33, C23, C13} = 4
-    {ACC_KEY_B, ACC_KEY_B, ACC_KEY_B},
+    {ACC_NEVER, ACC_KEY_B, ACC_NEVER}, // {C33, C23, C13} = 5
-    {ACC_NEVER, ACC_NEVER, ACC_NEVER},
+    {ACC_KEY_B, ACC_KEY_B, ACC_KEY_B}, // {C33, C23, C13} = 6
+    {ACC_NEVER, ACC_NEVER, ACC_NEVER}, // {C33, C23, C13} = 7
 };
 
 Mifare::Mifare(Ui::MainWindow *ui, Util *addr, QWidget *parent): QObject(parent)
@@ -105,11 +108,11 @@ QMap<QString, QString> Mifare::info(bool isRequiringOutput)
         for(auto line = lineList.begin(); line != lineList.end(); line++)
         {
             if(line->contains("UID"))
-                map["UID"] = line->replace("UID", "").replace(QRegularExpression("[^0-9a-fA-F]"), "").trimmed();
+                map["UID"] = line->remove("UID").remove(QRegularExpression("[^0-9a-fA-F]")).trimmed();
             else if(line->contains("ATQA"))
-                map["ATQA"] = line->replace("ATQA", "").replace(QRegularExpression("[^0-9a-fA-F]"), "").trimmed();
+                map["ATQA"] = line->remove("ATQA").remove(QRegularExpression("[^0-9a-fA-F]")).trimmed();
             else if(line->contains("SAK"))
-                map["SAK"] = line->replace("SAK", "").replace(QRegularExpression("\\[.+?\\]"), "").replace(QRegularExpression("[^0-9a-fA-F]"), "").trimmed();
+                map["SAK"] = line->remove("SAK").remove(QRegularExpression("\\[.+?\\]")).remove(QRegularExpression("[^0-9a-fA-F]")).trimmed();
         }
     }
     else
@@ -639,7 +642,7 @@ void Mifare::writeOne(TargetType targetType)
     bool isSuccessful = _writeblk(blockId, keyType, ui->MF_RW_keyEdit->text().toUpper(), ui->MF_RW_dataEdit->text(), targetType);
     if(isSuccessful)
     {
-        QMessageBox::information(parent, tr("Info"), tr("Success!"));
+        QMessageBox::information(parent, tr("Info"), tr("Succeed!"));
     }
     else
     {
@@ -710,7 +713,7 @@ void Mifare::writeSelected(TargetType targetType)
         }
     }
     if(failedBlocks.size() == 0)
-        QMessageBox::information(parent, tr("Info"), tr("Successful!"));
+        QMessageBox::information(parent, tr("Info"), tr("Succeed!"));
     else
     {
         QString suffix = "";
@@ -1312,9 +1315,13 @@ bool Mifare::data_isACBitsValid(const QString& text, QList<quint8>* returnHalfBy
     QList<quint8> halfBytes;
     for(int i = 0; i < 6; i++)
     {
+        // 6  7  8
+        // AB CD EF->
+        // {0xA, 0xB, 0xC, 0xD, 0xE, 0xF}
+        // {~C2x, ~C1x, C1x, ~C3x, C3, C2}
         halfBytes.append((val >> ((5 - i) * 4)) & 0xf);
     }
-    qDebug() << val;
+    // qDebug() << val;
     if((~halfBytes[0] & 0xf) == halfBytes[5] && (~halfBytes[1] & 0xf) == halfBytes[2] && (~halfBytes[3] & 0xf) == halfBytes[4])
     {
         if(returnHalfBytes != nullptr)
@@ -1330,9 +1337,12 @@ QList<quint8> Mifare::data_getACBits(const QString& text) //return empty QList i
     QList<quint8> halfBytes, result;
     if(data_isACBitsValid(text, &halfBytes))
     {
+        // data in halfbits:
+        // {~C2x, ~C1x, C1x, ~C3x, C3, C2}
         for(int i = 0; i < 4; i++)
         {
             result.append((((halfBytes[4] >> i) & 1) << 2) | (((halfBytes[5] >> i) & 1) << 1) | (((halfBytes[2] >> i) & 1) << 0));
+            // {Cx0, Cx1, Cx2, Cx3} (Cx0={C30, C20, C10})
         }
     }
     return result;

src/qdarkstyle/README.md

@@ -0,0 +1 @@
+From commit 6ff5fdf of [QDarkStyleSheet](https://github.com/ColinDuquesnoy/QDarkStyleSheet)

src/qdarkstyle/dark/darkstyle.qrc

@@ -0,0 +1,216 @@
+
+<RCC warning="WARNING! File created programmatically. All changes made in this file will be lost!">
+  <qresource prefix="qss_icons/dark">
+    <file>rc/arrow_down.png</file>
+    <file>rc/arrow_down@2x.png</file>
+    <file>rc/arrow_down_disabled.png</file>
+    <file>rc/arrow_down_disabled@2x.png</file>
+    <file>rc/arrow_down_focus.png</file>
+    <file>rc/arrow_down_focus@2x.png</file>
+    <file>rc/arrow_down_pressed.png</file>
+    <file>rc/arrow_down_pressed@2x.png</file>
+    <file>rc/arrow_left.png</file>
+    <file>rc/arrow_left@2x.png</file>
+    <file>rc/arrow_left_disabled.png</file>
+    <file>rc/arrow_left_disabled@2x.png</file>
+    <file>rc/arrow_left_focus.png</file>
+    <file>rc/arrow_left_focus@2x.png</file>
+    <file>rc/arrow_left_pressed.png</file>
+    <file>rc/arrow_left_pressed@2x.png</file>
+    <file>rc/arrow_right.png</file>
+    <file>rc/arrow_right@2x.png</file>
+    <file>rc/arrow_right_disabled.png</file>
+    <file>rc/arrow_right_disabled@2x.png</file>
+    <file>rc/arrow_right_focus.png</file>
+    <file>rc/arrow_right_focus@2x.png</file>
+    <file>rc/arrow_right_pressed.png</file>
+    <file>rc/arrow_right_pressed@2x.png</file>
+    <file>rc/arrow_up.png</file>
+    <file>rc/arrow_up@2x.png</file>
+    <file>rc/arrow_up_disabled.png</file>
+    <file>rc/arrow_up_disabled@2x.png</file>
+    <file>rc/arrow_up_focus.png</file>
+    <file>rc/arrow_up_focus@2x.png</file>
+    <file>rc/arrow_up_pressed.png</file>
+    <file>rc/arrow_up_pressed@2x.png</file>
+    <file>rc/base_icon.png</file>
+    <file>rc/base_icon@2x.png</file>
+    <file>rc/base_icon_disabled.png</file>
+    <file>rc/base_icon_disabled@2x.png</file>
+    <file>rc/base_icon_focus.png</file>
+    <file>rc/base_icon_focus@2x.png</file>
+    <file>rc/base_icon_pressed.png</file>
+    <file>rc/base_icon_pressed@2x.png</file>
+    <file>rc/branch_closed.png</file>
+    <file>rc/branch_closed@2x.png</file>
+    <file>rc/branch_closed_disabled.png</file>
+    <file>rc/branch_closed_disabled@2x.png</file>
+    <file>rc/branch_closed_focus.png</file>
+    <file>rc/branch_closed_focus@2x.png</file>
+    <file>rc/branch_closed_pressed.png</file>
+    <file>rc/branch_closed_pressed@2x.png</file>
+    <file>rc/branch_end.png</file>
+    <file>rc/branch_end@2x.png</file>
+    <file>rc/branch_end_disabled.png</file>
+    <file>rc/branch_end_disabled@2x.png</file>
+    <file>rc/branch_end_focus.png</file>
+    <file>rc/branch_end_focus@2x.png</file>
+    <file>rc/branch_end_pressed.png</file>
+    <file>rc/branch_end_pressed@2x.png</file>
+    <file>rc/branch_line.png</file>
+    <file>rc/branch_line@2x.png</file>
+    <file>rc/branch_line_disabled.png</file>
+    <file>rc/branch_line_disabled@2x.png</file>
+    <file>rc/branch_line_focus.png</file>
+    <file>rc/branch_line_focus@2x.png</file>
+    <file>rc/branch_line_pressed.png</file>
+    <file>rc/branch_line_pressed@2x.png</file>
+    <file>rc/branch_more.png</file>
+    <file>rc/branch_more@2x.png</file>
+    <file>rc/branch_more_disabled.png</file>
+    <file>rc/branch_more_disabled@2x.png</file>
+    <file>rc/branch_more_focus.png</file>
+    <file>rc/branch_more_focus@2x.png</file>
+    <file>rc/branch_more_pressed.png</file>
+    <file>rc/branch_more_pressed@2x.png</file>
+    <file>rc/branch_open.png</file>
+    <file>rc/branch_open@2x.png</file>
+    <file>rc/branch_open_disabled.png</file>
+    <file>rc/branch_open_disabled@2x.png</file>
+    <file>rc/branch_open_focus.png</file>
+    <file>rc/branch_open_focus@2x.png</file>
+    <file>rc/branch_open_pressed.png</file>
+    <file>rc/branch_open_pressed@2x.png</file>
+    <file>rc/checkbox_checked.png</file>
+    <file>rc/checkbox_checked@2x.png</file>
+    <file>rc/checkbox_checked_disabled.png</file>
+    <file>rc/checkbox_checked_disabled@2x.png</file>
+    <file>rc/checkbox_checked_focus.png</file>
+    <file>rc/checkbox_checked_focus@2x.png</file>
+    <file>rc/checkbox_checked_pressed.png</file>
+    <file>rc/checkbox_checked_pressed@2x.png</file>
+    <file>rc/checkbox_indeterminate.png</file>
+    <file>rc/checkbox_indeterminate@2x.png</file>
+    <file>rc/checkbox_indeterminate_disabled.png</file>
+    <file>rc/checkbox_indeterminate_disabled@2x.png</file>
+    <file>rc/checkbox_indeterminate_focus.png</file>
+    <file>rc/checkbox_indeterminate_focus@2x.png</file>
+    <file>rc/checkbox_indeterminate_pressed.png</file>
+    <file>rc/checkbox_indeterminate_pressed@2x.png</file>
+    <file>rc/checkbox_unchecked.png</file>
+    <file>rc/checkbox_unchecked@2x.png</file>
+    <file>rc/checkbox_unchecked_disabled.png</file>
+    <file>rc/checkbox_unchecked_disabled@2x.png</file>
+    <file>rc/checkbox_unchecked_focus.png</file>
+    <file>rc/checkbox_unchecked_focus@2x.png</file>
+    <file>rc/checkbox_unchecked_pressed.png</file>
+    <file>rc/checkbox_unchecked_pressed@2x.png</file>
+    <file>rc/line_horizontal.png</file>
+    <file>rc/line_horizontal@2x.png</file>
+    <file>rc/line_horizontal_disabled.png</file>
+    <file>rc/line_horizontal_disabled@2x.png</file>
+    <file>rc/line_horizontal_focus.png</file>
+    <file>rc/line_horizontal_focus@2x.png</file>
+    <file>rc/line_horizontal_pressed.png</file>
+    <file>rc/line_horizontal_pressed@2x.png</file>
+    <file>rc/line_vertical.png</file>
+    <file>rc/line_vertical@2x.png</file>
+    <file>rc/line_vertical_disabled.png</file>
+    <file>rc/line_vertical_disabled@2x.png</file>
+    <file>rc/line_vertical_focus.png</file>
+    <file>rc/line_vertical_focus@2x.png</file>
+    <file>rc/line_vertical_pressed.png</file>
+    <file>rc/line_vertical_pressed@2x.png</file>
+    <file>rc/radio_checked.png</file>
+    <file>rc/radio_checked@2x.png</file>
+    <file>rc/radio_checked_disabled.png</file>
+    <file>rc/radio_checked_disabled@2x.png</file>
+    <file>rc/radio_checked_focus.png</file>
+    <file>rc/radio_checked_focus@2x.png</file>
+    <file>rc/radio_checked_pressed.png</file>
+    <file>rc/radio_checked_pressed@2x.png</file>
+    <file>rc/radio_unchecked.png</file>
+    <file>rc/radio_unchecked@2x.png</file>
+    <file>rc/radio_unchecked_disabled.png</file>
+    <file>rc/radio_unchecked_disabled@2x.png</file>
+    <file>rc/radio_unchecked_focus.png</file>
+    <file>rc/radio_unchecked_focus@2x.png</file>
+    <file>rc/radio_unchecked_pressed.png</file>
+    <file>rc/radio_unchecked_pressed@2x.png</file>
+    <file>rc/toolbar_move_horizontal.png</file>
+    <file>rc/toolbar_move_horizontal@2x.png</file>
+    <file>rc/toolbar_move_horizontal_disabled.png</file>
+    <file>rc/toolbar_move_horizontal_disabled@2x.png</file>
+    <file>rc/toolbar_move_horizontal_focus.png</file>
+    <file>rc/toolbar_move_horizontal_focus@2x.png</file>
+    <file>rc/toolbar_move_horizontal_pressed.png</file>
+    <file>rc/toolbar_move_horizontal_pressed@2x.png</file>
+    <file>rc/toolbar_move_vertical.png</file>
+    <file>rc/toolbar_move_vertical@2x.png</file>
+    <file>rc/toolbar_move_vertical_disabled.png</file>
+    <file>rc/toolbar_move_vertical_disabled@2x.png</file>
+    <file>rc/toolbar_move_vertical_focus.png</file>
+    <file>rc/toolbar_move_vertical_focus@2x.png</file>
+    <file>rc/toolbar_move_vertical_pressed.png</file>
+    <file>rc/toolbar_move_vertical_pressed@2x.png</file>
+    <file>rc/toolbar_separator_horizontal.png</file>
+    <file>rc/toolbar_separator_horizontal@2x.png</file>
+    <file>rc/toolbar_separator_horizontal_disabled.png</file>
+    <file>rc/toolbar_separator_horizontal_disabled@2x.png</file>
+    <file>rc/toolbar_separator_horizontal_focus.png</file>
+    <file>rc/toolbar_separator_horizontal_focus@2x.png</file>
+    <file>rc/toolbar_separator_horizontal_pressed.png</file>
+    <file>rc/toolbar_separator_horizontal_pressed@2x.png</file>
+    <file>rc/toolbar_separator_vertical.png</file>
+    <file>rc/toolbar_separator_vertical@2x.png</file>
+    <file>rc/toolbar_separator_vertical_disabled.png</file>
+    <file>rc/toolbar_separator_vertical_disabled@2x.png</file>
+    <file>rc/toolbar_separator_vertical_focus.png</file>
+    <file>rc/toolbar_separator_vertical_focus@2x.png</file>
+    <file>rc/toolbar_separator_vertical_pressed.png</file>
+    <file>rc/toolbar_separator_vertical_pressed@2x.png</file>
+    <file>rc/transparent.png</file>
+    <file>rc/transparent@2x.png</file>
+    <file>rc/transparent_disabled.png</file>
+    <file>rc/transparent_disabled@2x.png</file>
+    <file>rc/transparent_focus.png</file>
+    <file>rc/transparent_focus@2x.png</file>
+    <file>rc/transparent_pressed.png</file>
+    <file>rc/transparent_pressed@2x.png</file>
+    <file>rc/window_close.png</file>
+    <file>rc/window_close@2x.png</file>
+    <file>rc/window_close_disabled.png</file>
+    <file>rc/window_close_disabled@2x.png</file>
+    <file>rc/window_close_focus.png</file>
+    <file>rc/window_close_focus@2x.png</file>
+    <file>rc/window_close_pressed.png</file>
+    <file>rc/window_close_pressed@2x.png</file>
+    <file>rc/window_grip.png</file>
+    <file>rc/window_grip@2x.png</file>
+    <file>rc/window_grip_disabled.png</file>
+    <file>rc/window_grip_disabled@2x.png</file>
+    <file>rc/window_grip_focus.png</file>
+    <file>rc/window_grip_focus@2x.png</file>
+    <file>rc/window_grip_pressed.png</file>
+    <file>rc/window_grip_pressed@2x.png</file>
+    <file>rc/window_minimize.png</file>
+    <file>rc/window_minimize@2x.png</file>
+    <file>rc/window_minimize_disabled.png</file>
+    <file>rc/window_minimize_disabled@2x.png</file>
+    <file>rc/window_minimize_focus.png</file>
+    <file>rc/window_minimize_focus@2x.png</file>
+    <file>rc/window_minimize_pressed.png</file>
+    <file>rc/window_minimize_pressed@2x.png</file>
+    <file>rc/window_undock.png</file>
+    <file>rc/window_undock@2x.png</file>
+    <file>rc/window_undock_disabled.png</file>
+    <file>rc/window_undock_disabled@2x.png</file>
+    <file>rc/window_undock_focus.png</file>
+    <file>rc/window_undock_focus@2x.png</file>
+    <file>rc/window_undock_pressed.png</file>
+    <file>rc/window_undock_pressed@2x.png</file>
+  </qresource>
+  <qresource prefix="qdarkstyle/dark">
+      <file>darkstyle.qss</file>
+  </qresource>
+</RCC>

src/qdarkstyle/dark/rc/.keep

@@ -0,0 +1 @@
+